The grouping API is pretty confusing so if you are willing to update the basic_tpsl example to demonstrate how to use the different groupings that would be great. At a minimum, you would need to get Lint passing before this can be merged

@traderben I'm thinking of adding another example for basic group order that creates a market order with tp and sl associated with it? How does that sound?

nvm, I'll just add that thing in basic_tpsl

nvm, I'll just add that thing in basic_tpsl

Either option sounds good to me. Thanks!

Added the example for market order with tp and sl with group order

still getting lint error for missing return type

hyperliquid/utils/signing.py:499:1: error: Function is missing a type
annotation for one or more arguments  [no-untyped-def]
    def order_wires_to_order_action(order_wires, builder=None, grouping: G...
    ^
Found 2 errors in 1 file (checked 54 source files

should I add Dict[str, Any] ?

still getting lint error for missing return type

hyperliquid/utils/signing.py:499:1: error: Function is missing a type
annotation for one or more arguments  [no-untyped-def]
    def order_wires_to_order_action(order_wires, builder=None, grouping: G...
    ^
Found 2 errors in 1 file (checked 54 source files

should I add Dict[str, Any] ?

I think it's better to have it return Any than Dict[str, Any] Another option would be to instead not add the type to grouping and leave the function untyped

still getting lint error for missing return type

hyperliquid/utils/signing.py:499:1: error: Function is missing a type
annotation for one or more arguments  [no-untyped-def]
    def order_wires_to_order_action(order_wires, builder=None, grouping: G...
    ^
Found 2 errors in 1 file (checked 54 source files

should I add Dict[str, Any] ?

I think it's better to have it return Any than Dict[str, Any] Another option would be to instead not add the type to grouping and leave the function untyped

Any for order_wires_to_order_action sounds good.

I've done the following for order_wires_to_order_action

def order_wires_to_order_action(order_wires: list[OrderWire], builder: Any = None, grouping: Grouping = "na") -> Any:
    action = {
        "type": "order",
        "orders": order_wires,
        "grouping": grouping,
    }
    if builder:
        action["builder"] = builder
    return action

I was thinking I could improve it by adding types to all params, like Optional[BuilderInfo]
, but that causes the issue as action doesn't have a type, lmk if action has a type defined, or if you want me to define it and add explicit types whereever possible.

For now this should work? No lint issue now.

Also, would love to pick up any other issues I can help with, just lmk.

Hello ser, anything here?

@traderben fixed the proposed changes

@traderben is there any other issue I can pick to work on?

@traderben is there any other issue I can pick to work on?

No thanks

I cleaned this up and included it in #230